Implement IAsyncDisposable from IConnectionMultiplexer by kimsey0 · Pull Request #2161

Implement IAsyncDisposable from IConnectionMultiplexer by kimsey0 · Pull Request #2161 · StackExchange/StackExchange.Redis

Conversation

Fixes #2160.

We may want to implement IAsyncDisposable in more public IDisposable classes which can dispose their resources asynchronously.

Hey @kimsey0 - we should add release notes and move the API to the Shipped set in-order but then good to go. Happy to take care of that to get this in if you want :)

kimsey0 marked this pull request as ready for review

July 21, 2022 12:22

@NickCraver: I moved the API change to shipped and added a new line under Unreleased in the release notes document. I haven't used Microsoft.CodeAnalysis.PublicApiAnalyzers before, so feel free to fix it if I've done something incorrectly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! 1 issue introduced with a null ref in dispose though - need to shuffle a bit on how that's handled (comments inline).

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

2 participants