PrepareScript should work for parameterless scripts; fix #2164 by mgravell · Pull Request #2166 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
PrepareScript should work for parameterless scripts; fix #2164#2166
PrepareScript should work for parameterless scripts; fix #2164#2166
Conversation
Copy link Copy Markdown
Collaborator
mgravell added 3 commits
June 21, 2022 14:43NickCraver approved these changes Jun 21, 2022
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looking good
mgravell
merged commit
bc0c5a2
into
main
mgravell
deleted the
issue-2164
branch
Copy link Copy Markdown
svalbuena
commented
Jun 23, 2022
svalbuena commented
Jun 23, 2022When are you planning to release this change @mgravell ? The CI build didn't publish it as a test failed
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Jun 23, 2022
mgravell commented
Jun 23, 2022retrying build; let's see if we can at least get it onto myget
Copy link Copy Markdown
svalbuena
commented
Jun 23, 2022
svalbuena commented
Jun 23, 2022it worked! thanks!!
Copy link Copy Markdown
svalbuena
commented
Jun 23, 2022
svalbuena commented
Jun 23, 2022Do you know when this will get published on nuget.org? I can only fetch it from there for production
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Jun 23, 2022
mgravell commented
Jun 23, 2022we discussed this in a meeting on Tuesday - I think we're planning to give it a day or so to see if anything else comes in from the recent release that needs urgent attention, and then get this out; how about if we haven't seen anything by Tuesday (simply because we have a recurring coordination meeting on Tuesdays), we get the release sorted out?
Copy link Copy Markdown
svalbuena
commented
Jun 23, 2022
svalbuena commented
Jun 23, 2022works fine for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment