PrepareScript should work for parameterless scripts; fix #2164 by mgravell · Pull Request #2166 · StackExchange/StackExchange.Redis

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mgravell

Copy link Copy Markdown

Collaborator

@mgravell mgravell commented

Jun 21, 2022

edited

Loading

fix breaking change introduced here - fixes #2164

Copy link Copy Markdown

Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looking good

@mgravell mgravell merged commit bc0c5a2 into main

Jun 21, 2022

@mgravell mgravell deleted the issue-2164 branch

June 21, 2022 14:04

@svalbuena

Copy link Copy Markdown

When are you planning to release this change @mgravell ? The CI build didn't publish it as a test failed

@mgravell

Copy link Copy Markdown

Collaborator Author

retrying build; let's see if we can at least get it onto myget

@svalbuena

Copy link Copy Markdown

it worked! thanks!!

@svalbuena

Copy link Copy Markdown

Do you know when this will get published on nuget.org? I can only fetch it from there for production

@mgravell

Copy link Copy Markdown

Collaborator Author

we discussed this in a meeting on Tuesday - I think we're planning to give it a day or so to see if anything else comes in from the recent release that needs urgent attention, and then get this out; how about if we haven't seen anything by Tuesday (simply because we have a recurring coordination meeting on Tuesdays), we get the release sorted out?

@svalbuena

Copy link Copy Markdown

works fine for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lua Script Cannot be Parsed after upgrading to 2.6.45

3 participants

@mgravell @svalbuena @NickCraver