add StreamGroupInfo EntriesRead and Lag by tvdias · Pull Request #2510 · StackExchange/StackExchange.Redis

@tvdias

@tvdias

@tvdias tvdias marked this pull request as draft

July 14, 2023 14:00

mgravell

@mgravell

Suggest also:

  • release notes update
  • test if possible (if server version is blockage, fine)

@tvdias

  • release notes update

Fixed on 287bacd

  • test if possible (if server version is blockage, fine)

Fixed on f0f0a1d

@tvdias tvdias marked this pull request as ready for review

July 18, 2023 13:52

@tvdias

@tvdias

@mgravell this is now ready. the last test that was added (on #2508) looks to be flaky and I had to retry the pipeline a couple of times until it works. also noticed it on the PR itself, that only worked on the 2nd pipeline run, when release notes were updated.

@tvdias

Hey @mgravell , I think this is ready to go. I'd squash it on merge because I had to create some dummy commits to trigger the build - idk if I could manually do it.

@tvdias

Hello @mgravell , can you please take a new look on this PR?

And please use the squash it on merge option, as I had created some dummy commits to trigger the builds (idk if I could manually do it).

NickCraver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current is looking great - thank you!