Support `HeartbeatConsistencyChecks` in `Clone()` by mgravell · Pull Request #2658 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
Support HeartbeatConsistencyChecks in Clone()#2658
Support HeartbeatConsistencyChecks in Clone()#2658
Conversation
Copy link Copy Markdown
Collaborator
release 2.7.23 added a ConfigurationOptions.HeartbeatConsistencyChecks option, but that option is not represented in Clone(); fix that
mgravell added 2 commits
February 27, 2024 10:18
Copy link Copy Markdown
Collaborator
NickCraver
commented
Feb 27, 2024
NickCraver commented
Feb 27, 2024Sooooooo I think I missed this because interval isn't in there either…
Copy link Copy Markdown
Collaborator
NickCraver
commented
Feb 27, 2024
NickCraver commented
Feb 27, 2024Thoughts on some reflection-based test for clone checking to prevent future misses?
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Feb 27, 2024
mgravell commented
Feb 27, 2024Sooooooo I think I missed this because interval isn't in there either…
added; I have no great ideas on the reflection thing - feel free to suggest
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Feb 27, 2024
mgravell commented
Feb 27, 2024maybe just a count of the fields on ConfigurationOptions with a known expected value:
Assert.Equals(43, fields.Length); // if this fails, check Clone() has been updated
Copy link Copy Markdown
Collaborator
NickCraver
commented
Feb 27, 2024
NickCraver commented
Feb 27, 2024+1 I like it - simple and effective we can get fancier if ever justified. Do you mind adding in this PR please? If slammed I can follow-up later in day too.
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Feb 27, 2024
mgravell commented
Feb 27, 2024@NickCraver already working on it
Copy link Copy Markdown
Collaborator Author
mgravell
commented
Feb 27, 2024
mgravell commented
Feb 27, 2024@NickCraver see 2a624a2
mgravell added 3 commits
February 27, 2024 12:02
mgravell
requested a review
from NickCraver
NickCraver approved these changes Feb 27, 2024
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
mgravell
merged commit
a517561
into
main
mgravell
deleted the
heartbeat-clone
branch
docs/ReleaseNotes.md
Show resolved
Hide resolved
docs/ReleaseNotes.md Show resolved Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants