chore(modal): update to svelte 5 runes apis by giamir · Pull Request #2017 · StackExchange/Stacks
Navigation Menu
{{ message }}
StackExchange / Stacks Public
- Notifications You must be signed in to change notification settings
- Fork 101
Merged
Conversation
Copy link Copy Markdown
Contributor
giamir
commented
Oct 24, 2025
giamir
commented
This PR updates the Modal component to the new Svelte 5 runes APIs.
Copy link Copy Markdown
🦋 Changeset detected
Latest commit: 198a39e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @stackoverflow/stacks-svelte | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Copy link Copy Markdown
✅ Deploy Preview for stacks-svelte ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 198a39e |
| 🔍 Latest deploy log | https://app.netlify.com/projects/stacks-svelte/deploys/68fb372b453021000896cc7e |
| 😎 Deploy Preview | https://deploy-preview-2017--stacks-svelte.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Copy link Copy Markdown
✅ Deploy Preview for stacks ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 198a39e |
| 🔍 Latest deploy log | https://app.netlify.com/projects/stacks/deploys/68fb372bb5f6200008c1c725 |
| 😎 Deploy Preview | https://deploy-preview-2017--stacks.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
giamir
requested review from
dancormier and
ttaylor-stack
dancormier approved these changes Oct 24, 2025
Copy link Copy Markdown
Contributor
dancormier
left a comment
dancormier
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, storybook examples work as expected, and code changes seem sensible. Thanks!
giamir
deleted the
SPARK-22/update-modal-to-svelte-5-apis
branch
stacks-tooling
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants