Add custom image.tag for all pods by cognifloyd · Pull Request #200 · StackStorm/stackstorm-k8s
Navigation Menu
{{ message }}
StackStorm / stackstorm-k8s Public
- Notifications You must be signed in to change notification settings
- Fork 119
Merged
Add custom image.tag for all pods#200
arm4b merged 2 commits intoStackStorm:masterfrom
Add custom image.tag for all pods#200
arm4b merged 2 commits intoStackStorm:masterfrom
Conversation
Copy link Copy Markdown
Member
cognifloyd
commented
Jun 18, 2021
cognifloyd
commented
This adds an image.tag value for each of the pods.
Partially implements #132 (this only adds custom image.tag, not image.repository).
- add image.tag overrides for all deployments
- add image.tag overrides for all jobs
cognifloyd added 2 commits
June 18, 2021 15:01
pull-request-size
bot
added
the
size/L
label
Jun 18, 2021
cognifloyd
mentioned this pull request
cognifloyd
added
feature
RFR
labels
cognifloyd
requested a review
from arm4b
cognifloyd
changed the title
Add custom image.tags for all pods
Add custom image.tag for all pods
Copy link Copy Markdown
Contributor
ericreeves
commented
Jun 21, 2021
ericreeves commented
Jun 21, 2021+1. Yes please.
This would allow me to easily utilize stable 3.4 containers with stackstorm-ha without having to maintain a patched Charts.yaml or a big Kustomize patch!
arm4b approved these changes Jun 26, 2021
Copy link Copy Markdown
Member
arm4b
left a comment
arm4b
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Thanks for the helpful addition 👍
arm4b
merged commit
2e2efe8
into
StackStorm:master
cognifloyd
removed
the
RFR
label
This was referenced
Jun 26, 2021cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request
Jun 29, 2021Follow up for StackStorm#200
cognifloyd
mentioned this pull request
Copy link Copy Markdown
Member Author
cognifloyd
commented
Jun 29, 2021
cognifloyd commented
Jun 29, 2021Oops. I missed one tag in a helper template. Pushed a follow up in #214.
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request
Jun 29, 2021Follow up for StackStorm#200
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request
Jun 29, 2021Follow up for StackStorm#200
arm4b added a commit that referenced this pull request
Jun 29, 2021Fix tag in helper (follow up to #200)
ericreeves pushed a commit to alertlogic/stackstorm-ha that referenced this pull request
Jul 9, 2021Follow up for StackStorm#200
cognifloyd
deleted the
image-tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment