Add optional dnsPolicy, dnsConfig to all pods by cognifloyd · Pull Request #201 · StackStorm/stackstorm-k8s
Navigation Menu
{{ message }}
StackStorm / stackstorm-k8s Public
- Notifications You must be signed in to change notification settings
- Fork 119
Merged
Add optional dnsPolicy, dnsConfig to all pods#201
arm4b merged 2 commits intoStackStorm:masterfrom
Add optional dnsPolicy, dnsConfig to all pods#201
arm4b merged 2 commits intoStackStorm:masterfrom
Conversation
Copy link Copy Markdown
Member
Adds dnsPolicy and dnsConfig to all pods based on .Values.dnsPolicy and .Values.dnsConfig if defined.
I do not think having different dnsConfig/dnsPolicy per pod makes much sense, so this is provides only one common value for all the pods defined by stackstorm-ha, not one-per-pod like other settings.
dnsPolicy: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy
dnsConfig: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config
pull-request-size
bot
added
the
size/L
label
Jun 19, 2021
cognifloyd
added
feature
RFR
labels
cognifloyd
requested a review
from arm4b
cognifloyd
force-pushed
the
internal-dns
branch
from
2f5e220 to
7ecda08
Compare
Copy link Copy Markdown
Member Author
cognifloyd
commented
Jun 26, 2021
cognifloyd commented
Jun 26, 2021rebased on master
cognifloyd
force-pushed
the
internal-dns
branch
5 times, most recently
from
d086c1e to
e37daf9
Compare
cognifloyd
added
the
K8s
label
cognifloyd
force-pushed
the
internal-dns
branch
2 times, most recently
from
c250d7b to
5dc5e40
Compare
cognifloyd added 2 commits
July 5, 2021 11:11
cognifloyd
force-pushed
the
internal-dns
branch
from
5dc5e40 to
67c4c1e
Compare
Copy link Copy Markdown
Member Author
@armab This is straight forward as well and should be quick to review.
It adds dnsPolicy and dnsConfig to all pods (based on .Values.dnsPolicy and .Values.dnsConfig if defined). It only adds lines; it does not change any existing lines.
Thanks again for all your reviews.
arm4b approved these changes Jul 6, 2021
Copy link Copy Markdown
Member
arm4b
left a comment
arm4b
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Agree about making this setting common for all the Pods
arm4b
merged commit
d2691ee
into
StackStorm:master
cognifloyd
removed
the
RFR
label
cognifloyd
deleted the
internal-dns
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment