Template the contents of st2.config and the values in st2chatops.env. by cognifloyd · Pull Request #249 · StackStorm/stackstorm-k8s

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@cognifloyd

Copy link Copy Markdown

Member

Resolves #232

@cognifloyd cognifloyd added enhancement

New feature or request

Helm RFR labels

Sep 13, 2021

@cognifloyd cognifloyd requested a review from arm4b

September 13, 2021 20:50

@cognifloyd cognifloyd self-assigned this

Sep 13, 2021

@pull-request-size pull-request-size bot added the size/XS

PR that changes 0-9 lines. Quick fix/merge.

label

Sep 13, 2021
Copy link Copy Markdown

Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really helpful! 💯

@cognifloyd cognifloyd merged commit b7fa4ab into StackStorm:master

Sep 29, 2021

@cognifloyd cognifloyd removed the RFR label

Sep 29, 2021

@cognifloyd cognifloyd deleted the tpl-config branch

November 11, 2021 18:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cognifloyd cognifloyd

Labels

enhancement

New feature or request

Helm size/XS

PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Use tpl to template config from values.

2 participants

@cognifloyd @arm4b