Use envFrom for ST2_AUTH_USERNAME/PASSWORD by cognifloyd · Pull Request #257 · StackStorm/stackstorm-k8s
Navigation Menu
{{ message }}
StackStorm / stackstorm-k8s Public
- Notifications You must be signed in to change notification settings
- Fork 119
Merged
cognifloyd merged 6 commits intoStackStorm:masterfrom
Oct 22, 2021Merged
Use envFrom for ST2_AUTH_USERNAME/PASSWORD#257
cognifloyd merged 6 commits intoStackStorm:masterfrom
Use envFrom for ST2_AUTH_USERNAME/PASSWORD#257
cognifloyd merged 6 commits intoStackStorm:masterfrom
Conversation
Copy link Copy Markdown
Member
cognifloyd
commented
Oct 18, 2021
cognifloyd
commented
This simplifies using the st2-auth secret so we only need to load it with envFrom instead of listing each var separately.
pull-request-size
bot
added
the
size/M
label
Oct 18, 2021
cognifloyd
added
the
Helm
label
cognifloyd
self-assigned this
cognifloyd added 4 commits
October 18, 2021 11:14
cognifloyd
requested a review
from arm4b
cognifloyd
added
the
RFR
label
cognifloyd
enabled auto-merge
arm4b reviewed Oct 22, 2021
CHANGELOG.md
Outdated
Show resolved
Hide resolved
arm4b approved these changes Oct 22, 2021
Copy link Copy Markdown
Member
arm4b
left a comment
arm4b
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
cognifloyd
merged commit
cbde210
into
StackStorm:master
cognifloyd
deleted the
envfrom-simplify
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment