apply annotations to deployments and jobs, not just pods by cognifloyd · Pull Request #270 · StackStorm/stackstorm-k8s

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@cognifloyd

Copy link Copy Markdown

Member

Apply annotations (added to Pods in #195) to Deployments and Jobs.

I need to apply annotations to Deployments due to cluster policies that require annotations on Deployments and not just on Pods.

@pull-request-size pull-request-size bot added the size/M

PR that changes 30-99 lines. Good size to review.

label

Dec 2, 2021

@cognifloyd cognifloyd requested a review from arm4b

December 2, 2021 04:12

@cognifloyd cognifloyd added enhancement

New feature or request

K8s labels

Dec 2, 2021

@cognifloyd cognifloyd force-pushed the deployment-annotations branch from 8595007 to 943db16 Compare

December 2, 2021 04:14

@cognifloyd cognifloyd self-assigned this

Dec 2, 2021
Copy link Copy Markdown

Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cognifloyd cognifloyd merged commit 87295be into StackStorm:master

Dec 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cognifloyd cognifloyd

Labels

enhancement

New feature or request

K8s size/M

PR that changes 30-99 lines. Good size to review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cognifloyd @arm4b