prevent init containers from persisting across helm upgrade by guzzijones · Pull Request #375 · StackStorm/stackstorm-k8s

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@guzzijones

Copy link Copy Markdown

Contributor

this pr prevents st2packs init containers from persisting across upgrades.
fixes #260

@pull-request-size pull-request-size bot added the size/XS

PR that changes 0-9 lines. Quick fix/merge.

label

Sep 7, 2023

arm4b

arm4b previously approved these changes Sep 15, 2023

Copy link Copy Markdown

Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the https://github.com/StackStorm/stackstorm-k8s/blob/master/CHANGELOG.md?

Otherwise looks good.

@arm4b arm4b dismissed their stale review

September 15, 2023 14:54

potential bug

guzzijones and others added 2 commits

September 25, 2023 22:52
Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
add entry for pr

@guzzijones guzzijones merged commit 1156ae2 into StackStorm:master

Oct 9, 2023

@cognifloyd cognifloyd added bug

Something isn't working

Helm K8s labels

Apr 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winem winem winem approved these changes

@cognifloyd cognifloyd Awaiting requested review from cognifloyd

+1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Something isn't working

Helm K8s size/XS

PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StackStorm-ha chart doesn't remove old initContainers for packs

4 participants

@guzzijones @winem @arm4b @cognifloyd