Presleep for st2auth, st2web, st2api, st2stream by guzzijones · Pull Request #382 · StackStorm/stackstorm-k8s
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 119
Conversation
guzzijones
changed the title
wip - Presleep for st2auth, st2web, st2api, st2stream
Presleep for st2auth, st2web, st2api, st2stream
cognifloyd added a commit that referenced this pull request
Dec 16, 2024Adds a conditional to skip adding the preStop sleep (added in #382) for clusters that do not use kubelet. My cluster, for example, uses the Calico eBPF-based dataplane, so it does not rely on kubelet or iptables. When I tried using "0" to skip this, it was somehow converted to an integer in the generated yaml file causing some failures during helm upgrade. So, this also adds quotes around the preStopSleep. Also, the changelog was missing the PR that added the preStopSleep, so add it, and fix the order of another changelog entry to follow the merge order and link to the PR instead of the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters