Secret DataStore Crypto Key should not be created when existing provided by bmarick · Pull Request #385 · StackStorm/stackstorm-k8s
Navigation Menu
{{ message }}
StackStorm / stackstorm-k8s Public
- Notifications You must be signed in to change notification settings
- Fork 119
Merged
guzzijones merged 2 commits intoStackStorm:masterfrom
Jan 23, 2024Merged
Conversation
Copy link Copy Markdown
Contributor
Changes:
- Update
secrets_datastore_crypto_key.yamlto prevent creation whenst2.existingDatastoreSecretis set - Add unit tests to validate changes
- Fix unit test syntax
Addresses Issue #386
…value provided Fix unit test syntax
pull-request-size
bot
added
the
size/L
label
Jan 19, 2024guzzijones approved these changes Jan 23, 2024
Copy link Copy Markdown
Contributor
guzzijones
left a comment
guzzijones
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
guzzijones
merged commit
44aa43a
into
StackStorm:master
bmarick
deleted the
disableGenerateDatastoreCryptoKey
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants