Support for Base64url with case insensitive padding by prince-chrismc · Pull Request #219 · Thalhammer/jwt-cpp
Navigation Menu
{{ message }}
Thalhammer / jwt-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 302
Merged
prince-chrismc merged 17 commits intoThalhammer:masterfrom
Sep 19, 2022Merged
Support for Base64url with case insensitive padding#219
prince-chrismc merged 17 commits intoThalhammer:masterfrom
Support for Base64url with case insensitive padding#219
prince-chrismc merged 17 commits intoThalhammer:masterfrom
Conversation
prince-chrismc added 5 commits
March 11, 2022 22:45prince-chrismc commented Mar 16, 2022
Copy link
Collaborator Author
prince-chrismc
left a comment
prince-chrismc
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love a sanity check but I think I found an easy way to fix the base64url capitalization bug
include/jwt-cpp/base.h
Outdated
Show resolved
Hide resolved
include/jwt-cpp/base.h Outdated Show resolved Hide resolved
include/jwt-cpp/base.h
Outdated
Show resolved
Hide resolved
include/jwt-cpp/base.h Outdated Show resolved Hide resolved
tests/BaseTest.cpp
Show resolved
Hide resolved
tests/BaseTest.cpp Show resolved Hide resolved
prince-chrismc
requested a review
from Thalhammer
prince-chrismc added 12 commits
June 14, 2022 09:10…ic values" This reverts commit b9be15e.
prince-chrismc
marked this pull request as ready for review
Copy link
Collaborator Author
prince-chrismc
commented
Sep 19, 2022
prince-chrismc commented
Sep 19, 2022@Thalhammer When you have a chance, I'd love a second set of eyes to double check my logic 🙏
Thalhammer approved these changes Sep 19, 2022
Copy link
Owner
Thalhammer
commented
Sep 19, 2022
Thalhammer commented
Sep 19, 2022Looks good to me ;)
prince-chrismc
merged commit
0628011
into
Thalhammer:master
prince-chrismc
deleted the
base64url-lower
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Comments