Allow generic access to JWT header and payload by prince-chrismc · Pull Request #251 · Thalhammer/jwt-cpp
Navigation Menu
{{ message }}
Thalhammer / jwt-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 302
Merged
prince-chrismc merged 11 commits intoThalhammer:masterfrom
Oct 2, 2022Merged
Allow generic access to JWT header and payload#251
prince-chrismc merged 11 commits intoThalhammer:masterfrom
Allow generic access to JWT header and payload#251
prince-chrismc merged 11 commits intoThalhammer:masterfrom
Conversation
Copy link
Collaborator
prince-chrismc
commented
Oct 1, 2022
prince-chrismc
commented
closes #248 by allow direct access to the JSON. This section of code is only used to debug so it should be better to not have the hassle of the claim wrapping the data
prince-chrismc added 10 commits
October 1, 2022 21:39
prince-chrismc
mentioned this pull request
prince-chrismc
requested a review
from Thalhammer
Thalhammer approved these changes Oct 1, 2022
Copy link
Owner
Thalhammer
left a comment
Thalhammer
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty severe API break though, but given I wanna get rid of claim in the long term anyway I am fine with that.
Copy link
Collaborator Author
prince-chrismc
commented
Oct 2, 2022
prince-chrismc commented
Oct 2, 2022Yep! Sever > surprise
This way it's very obvious the need to update the code... instead of not having access to old memeber functions.
prince-chrismc
merged commit
cba92ab
into
Thalhammer:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Comments