added convenience function for no base64 der to pem by dennisyakovlev · Pull Request #283 · Thalhammer/jwt-cpp
Navigation Menu
{{ message }}
Thalhammer / jwt-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 302
Merged
Thalhammer merged 2 commits intoThalhammer:masterfrom
Mar 14, 2023Merged
added convenience function for no base64 der to pem#283
Thalhammer merged 2 commits intoThalhammer:masterfrom
added convenience function for no base64 der to pem#283
Thalhammer merged 2 commits intoThalhammer:masterfrom
Conversation
Copy link
Contributor
dennisyakovlev
commented
Mar 11, 2023
dennisyakovlev
commented
I think a helper function for der to pem cert if original is not base64 encoded would nice.
prince-chrismc approved these changes Mar 11, 2023
Thalhammer reviewed Mar 13, 2023
Copy link
Owner
Thalhammer
left a comment
Thalhammer
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks, I am fine with it otherwise.
include/jwt-cpp/jwt.h
Outdated
Show resolved
Hide resolved
include/jwt-cpp/jwt.h Outdated Show resolved Hide resolved
include/jwt-cpp/jwt.h
Outdated
Show resolved
Hide resolved
include/jwt-cpp/jwt.h Outdated Show resolved Hide resolved
prince-chrismc approved these changes Mar 14, 2023
Thalhammer
merged commit
c2b43e6
into
Thalhammer:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
Comments