Remove unused header by ErwanLegrand · Pull Request #329 · Thalhammer/jwt-cpp
Navigation Menu
{{ message }}
Thalhammer / jwt-cpp Public
- Notifications You must be signed in to change notification settings
- Fork 302
Merged
Thalhammer merged 1 commit intoThalhammer:masterfrom
Feb 6, 2024Merged
Thalhammer merged 1 commit intoThalhammer:masterfrom
Thalhammer merged 1 commit intoThalhammer:masterfrom
Conversation
Copy link
Contributor
ErwanLegrand
commented
Feb 5, 2024
ErwanLegrand
commented
The title tells it all. The codecvt header is no longer used in jwt-cpp therefore there is no reason to keep including it.
Thalhammer approved these changes Feb 6, 2024
Copy link
Owner
Thalhammer
left a comment
Thalhammer
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. codecvt is deprecated in C++17 anyway and we don't use it anymore.
Thalhammer
merged commit
3e029c7
into
Thalhammer:master
ErwanLegrand
deleted the
old_gcc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Comments