Fix share access to attachments for notes protected by login:password by x1arch · Pull Request #7828 · TriliumNext/Trilium
Summary of Changes
Hello @x1arch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the sharing functionality for notes protected by credentials, specifically by improving how attachments and other embedded content are accessed. It introduces flexible authentication mechanisms using cookies or query parameters to ensure secure delivery of content, alongside new configuration options to customize the shared page layout and content visibility.
Highlights
- Share Access for Protected Notes: Introduced cookie-based and query-based authorization for attachments and assets within notes protected by login:password, addressing the issue where browsers do not send Authorization headers for these resources.
- New Share Control Attributes: Added several new labels to provide fine-grained control over shared content:
#shareExcludeto completely exclude a note from sharing,#shareTemplateNoPrevNextto hide bottom navigation,#shareTemplateNoLeftPanelto hide the left panel,#shareContentAccessto manually configure content access authentication (cookie, query, or basic), and#shareAccessTokenTimeoutto set token expiration. - Content Access Token Management: Implemented a
ContentAccessorclass to manage tokens for content access, ensuring a single token can be used for multiple accesses and preventing user interference. - Dynamic URL Rewriting: Modified the content renderer to dynamically append content access tokens to URLs for various assets (CSS, JS, images, PDFs, attachments) when query-based authentication is enabled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩