Support for parsing optional properties (class & interface) by ondratra · Pull Request #80

Support for parsing optional properties (class & interface) by ondratra · Pull Request #80 · buehler/node-typescript-parser

This merge adds new flag optional to PropertyDeclaration.
It is true for TS properties defined optional e.g. { myProperty?: string }

I am not sure what caused fail check in CI. @buehler can you please check this pull request and accept it if possible, please? (or tell me what is wrong)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!
Nice, but there are tests missing ;-) maybe that is why the codecov check fails. Can you add a test for an optional property?

Yes I can :) I am just little bit confused where to put the tests' code. Can you tell me how to create new test in project's structure? (/test folder seems quite complex to me :) )

I can and I will, but first I'm gonna finish my holiday :-) I'll be back in 1 week.

hmm I could add the PR and add the tests by myself so you get an example. I'll write the reference in this PR as a response for you.

buehler added a commit that referenced this pull request

Jul 31, 2018

Add tests for isOptional properties and methods (#80) and
the same flag to methods.