Fix #1647 by cspotcode · Pull Request #1648 · TypeStrong/ts-node

@cspotcode

@codecov

@johnnyreilly

thanks for this @cspotcode - may well try and make use of the code here to address the same issue in ts-loader. Should you discover issues with the approach you've adopted, it'd be awesome if you could share them here (I'm assuming there aren't, but good to mention just in case 😄 )

TypeStrong/ts-loader#1421

@cspotcode

@johnnyreilly definitely, yeah I'll let you know if anything breaks.

I'm not sure there's a strong reason to share code in this case. But if there is anything you want to share in the future, I recently got access to the @typestrong scope on npm. I requested access for something else -- @typestrong/ts-mockito -- but we could also use it for any shared types or helpers or whatnot.

@johnnyreilly

Nice! Yeah in my PR I'm doing a little copy pasta from your implementation, but right now it's pretty minimal.

That's definitely a useful tool to have.

This was referenced

Mar 1, 2022

This was referenced

Apr 16, 2022

This was referenced

Apr 23, 2022

This was referenced

May 1, 2022

This was referenced

May 9, 2022

@Odida Odida mentioned this pull request

Jul 17, 2024