[BREAKING] Replace console.log with process.stderr by d3xter666 · Pull Request #930

[BREAKING] Replace console.log with process.stderr by d3xter666 · Pull Request #930 · UI5/cli

Conversation

flovogt changed the title ~~[BRAKING] Replace console.log with process.stderr~~ [BREAKING] Replace console.log with process.stderr

Feb 23, 2024

This was referenced

Feb 23, 2024

Comment on lines +18 to +19

		process.stderr.write(hashSum.digest("hex"));
		process.stderr.write("\n");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to adjust any of those scripts. They're not related to the productive shipment of packages and usage of console.log seems to be totally valid to me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I was wondering too. There's no need and nobody consumes these scripts outside of this repository. So we could also abandon this PR

d3xter666 added a commit to SAP/ui5-server that referenced this pull request

Feb 29, 2024