Use JavaCC to generate udunits code at build time by lesserwhirls · Pull Request #1461 · Unidata/netcdf-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lesserwhirls

Copy link Copy Markdown

Member

@lesserwhirls lesserwhirls commented

Jul 18, 2025

edited

Loading

Description of Changes

Rather than relying on checked-in generated code, use javacc to generate code from the JavaCC grammar file at build time.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"
Rather than relying on checked-in generated code, use javacc to generate
code from the JavaCC grammar file at build time.

@lesserwhirls lesserwhirls added this to the v5.9.0 milestone

Jul 18, 2025

@lesserwhirls lesserwhirls added enhancement

New feature or request

internal: udunits

Issues related to the package ucar.units (udunits)

labels

Jul 18, 2025

@lesserwhirls lesserwhirls marked this pull request as ready for review

July 18, 2025 20:15

@lesserwhirls lesserwhirls merged commit 950b3d0 into Unidata:maint-5.x

Jul 18, 2025

16 checks passed

@lesserwhirls lesserwhirls deleted the javacc branch

July 18, 2025 20:19

@rschmunk rschmunk mentioned this pull request

Aug 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

New feature or request

internal: udunits

Issues related to the package ucar.units (udunits)

Projects

None yet

Milestone

v5.9.0

Development

Successfully merging this pull request may close these issues.

1 participant

@lesserwhirls