Scan service loader once for filters by lesserwhirls · Pull Request #1466 · Unidata/netcdf-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lesserwhirls

Copy link Copy Markdown

Member

@lesserwhirls lesserwhirls commented

Aug 6, 2025

edited

Loading

Description of Changes

Use a static initializer to scan for filters instead of scanning for each getFilter call. Fixes #1348

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@lesserwhirls lesserwhirls added bug

Something isn't working

filters

Issues related to filters

labels

Aug 6, 2025

@lesserwhirls lesserwhirls added this to the v5.9.0 milestone

Aug 6, 2025

@lesserwhirls lesserwhirls marked this pull request as ready for review

August 6, 2025 13:59
Use a static initializer to scan for filters instead of scanning for
each getFilter call. Fixes Unidata#1348

@lesserwhirls lesserwhirls marked this pull request as draft

August 6, 2025 14:01

@lesserwhirls lesserwhirls marked this pull request as ready for review

August 6, 2025 14:41

@lesserwhirls lesserwhirls merged commit e89a2bb into Unidata:maint-5.x

Aug 6, 2025

16 checks passed

@lesserwhirls lesserwhirls deleted the filters branch

August 6, 2025 17:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Something isn't working

filters

Issues related to filters

Projects

None yet

Milestone

v5.9.0

Development

Successfully merging this pull request may close these issues.

Filters scans service loader over and over

1 participant

@lesserwhirls