Load EnhancementProviders upon VariableDS instantiation by lesserwhirls · Pull Request #1478 · Unidata/netcdf-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lesserwhirls

Copy link Copy Markdown

Member

@lesserwhirls lesserwhirls commented

Aug 29, 2025

edited

Loading

Description of Changes

ServiceLoader instances are not thread-safe, so rather than share a static instance, load the provides once upon instantiation of the VariableDS class. Fixes #1477

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"
ServiceLoader instances are not thread-safe, so rather than share a
static instance, load the provides once upon instantiation of the
VariableDS class. Fixes Unidata#1477

@lesserwhirls lesserwhirls added this to the 5.9.1 milestone

Aug 29, 2025

@lesserwhirls lesserwhirls added the bug

Something isn't working

label

Aug 29, 2025

@lesserwhirls lesserwhirls marked this pull request as ready for review

August 29, 2025 23:03

@lesserwhirls lesserwhirls merged commit 106ba30 into Unidata:maint-5.x

Aug 29, 2025

16 checks passed

@lesserwhirls lesserwhirls deleted the gh-1477 branch

August 29, 2025 23:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

5.9.1

Development

Successfully merging this pull request may close these issues.

NoSuchElementException from VariableDS in multi-threaded environment

1 participant

@lesserwhirls