ClientDriven Sample - Welcome Dialog and Table of Contents [MTT-8693] [MTT-8697] by FabianStoll · Pull Request #262 · Unity-Technologies/com.unity.multiplayer.samples.bitesize

@FabianStoll

Description

Adds the standard Welcome Dialog and Table of Contents from the in-editor tutorials package to the ClientDriven Sample.

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8693
https://jira.unity3d.com/browse/MTT-8697

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

# Conflicts:
#	CHANGELOG.md

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

@FabianStoll

# Conflicts:
#	CHANGELOG.md

bastienunity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion for the forum link, but that's probably fine to land without it.
Regarding the icons, @selenaayang did a pass on the new Template with updated designs, maybe you'd like to re-use them in the sample too: https://jira.unity3d.com/browse/MTT-9640, but again, not blocking if we want to land this PR.

@FabianStoll

@FabianStoll

@FabianStoll

Addressed the comments @bastienunity , please have a quick look again 🙂

bastienunity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the icons path should be clean to avoid any unforeseen issues with strange characters in the Assets folder.

@FabianStoll

@FabianStoll

RikuTheFuffs

bastienunity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me!

@FabianStoll FabianStoll deleted the feat/client-driven/MTT-8697-welcome-dialog branch

December 2, 2024 16:22