ClientDriven Sample - Welcome Dialog and Table of Contents [MTT-8693] [MTT-8697] by FabianStoll · Pull Request #262 · Unity-Technologies/com.unity.multiplayer.samples.bitesize
Description
Adds the standard Welcome Dialog and Table of Contents from the in-editor tutorials package to the ClientDriven Sample.
Issue Number(s)
https://jira.unity3d.com/browse/MTT-8693
https://jira.unity3d.com/browse/MTT-8697
Contribution checklist
- Tests have been added for the project and/or any internal package
- Release notes have been added to the project changelog file
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- JIRA ticket ID is in the PR title or at least one commit message
- Include the ticket ID number within the body message of the PR to create a hyperlink
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion for the forum link, but that's probably fine to land without it.
Regarding the icons, @selenaayang did a pass on the new Template with updated designs, maybe you'd like to re-use them in the sample too: https://jira.unity3d.com/browse/MTT-9640, but again, not blocking if we want to land this PR.
Addressed the comments @bastienunity , please have a quick look again 🙂
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the icons path should be clean to avoid any unforeseen issues with strange characters in the Assets folder.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me!
FabianStoll
deleted the
feat/client-driven/MTT-8697-welcome-dialog
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters