Cognito import from assets feature by CedricProfessionnel · Pull Request #415 · UniversalDataTool/universal-data-tool
Enable the import from assets
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most important thing to fix is to avoid loading in the full dataset unless you absolutely have to. The Import dialog isn't rendered conditionally but uses useDataset, so you're actually loading in the dataset anywhere where it's rendered, which will delays and extra bandwidth for people even if they're not using s3
@CedricProfessionnel is this ready to review again? I see that I'm a pending reviewer but there's also one change requested so I'm not sure
@CedricProfessionnel is this ready to review again? I see that I'm a pending reviewer but there's also one change requested so I'm not sure
Yes, it is.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing you'll notice is that dialog animations for closing won't work now, but this is a small price to pay for the ease of dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters