Add support for SRP Apple login by MattKiazyk · Pull Request #393 · XcodesOrg/xcodes
Apple switched up their login to now use a Secure Remote Password type of algorithm. This add support for it, so a user can login properly.
Fixes #388
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattKiazyk , I've run this locally to download the 16.2 Beta and it worked for me
Here's what I did:
swift build -c release
.build/release/xcodes install 16.2 Beta
I think this should have tested the flow that you changed, right?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is working for me and using the SRP login! Thanks @MattKiazyk
Edit: I have not validated the implementation aside from checking that it works. Happy to compare to a reference implementation or other documentation if you have a link/resource for me to compare to though!
MattKiazyk
changed the title
fix: add support for SRP Apple login
Add support for SRP Apple login
dfed
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters