Printlns in simulation.rs are changed to debugs. by DmytroTym · Pull Request #6 · ZenGo-X/round-based-protocol

@DmytroTym

@DmytroTym

@survived

Does it compile on your machine? I have this error:

error: unexpected end of macro invocation
   --> src/dev/simulation.rs:197:13
    |
197 |             debug!();
    |             ^^^^^^^^^ missing tokens in macro arguments

@DmytroTym

@DmytroTym

@survived

Great! Do you think you could also enable logging in integration tests? Just to demonstrate that it's possible to trace state changes through the execution.

@DmytroTym

@DmytroTym

Only enabled it for the first test since the other two do not use simulation.

survived

thiserror = "1.0.23"
serde = { version = "1.0", features = ["derive"] }
log = "0.4.14"
env_logger = "0.9.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need env_logger only for tests, maybe move to [dev-dependencies]?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@survived survived linked an issue

Sep 15, 2021

that may be closed by this pull request

@DmytroTym

@survived

survived pushed a commit that referenced this pull request

Sep 15, 2021

@DmytroTym