Home Original page

Readme update for deleting caches by t-dedah · Pull Request #981 · actions/cache

Conversation

kotewar

pallavx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Is it possible (and a good idea?) to add another sample indicating how to delete cache for a specific PR?

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

bishal-pdMSFT

GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
```

## Known practices and workarounds

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should move the new section to workarounds.md and leave a cross ref below. And probably rename to tips-and-workarounds.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done, seems like a good use-case that can be linked from Known practices and workarounds

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay either way

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour as this can be the practice in readme to put any tips in separate file..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

bishal-pdMSFT

bishal-pdMSFT

echo "Fetching list of cache key"
cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH | cut -f 1 )

set +e

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for this. I assume this is useful in case deleting a cache fails.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@pallavx

Looks good to me.

Is it possible (and a good idea?) to add another sample indicating how to delete cache for a specific PR?

IMO, we should have 2 examples

  1. Delete caches for a given branch (this is being done in the latest commit)
  2. Delete caches for all PR branches (this was included in the first iteration, but has now been removed)

These 2 seems like common customer use-cases and guiding examples for these will help.

@bishal-pdMSFT @pdotl opinions on this?

bishal-pdMSFT

@Jimimaku

Beschreibung

Diese PR fügt einen Abschnitt in der Readme-Datei hinzu, um einen Workflow für die Automatisierung des Löschprozesses von Caches hinzuzufügen, die für Pull-Anforderungen erstellt wurden.Deleting cache

Motivation und Kontext

Problem -https://github.com/github/c2c-actions-cats/issues/749ADR -https://github.com/github/c2c-actions/blob/16b328cd311a04402a2ea003444674eaa5b96701/docs/teams/platform/adrs/artifact-cache/3901-branch-based-cache-eviction.md

Wie wurde das getestet?

Ich habe den Workflow auf meinen persönlichen Repos getestet

Screenshots (falls zutreffend):

Arten von Änderungen

  • Bugfix (geschützte Änderung, die ein Problem behebt)
  • Neue Funktion (geschützte Änderung, die Funktionalität hinzufügt)
  • Wichtige Änderung (Korrektur oder Feature, das zu einer Änderung der vorhandenen Funktionalität führen würde)
  • Dokumentation (README oder Dokumente hinzufügen oder aktualisieren)

Prüfliste:

  • Mein Code folgt dem Codestil dieses Projekts.
  • Meine Änderung erfordert eine Änderung der Dokumentation.
  • Ich habe die Dokumentation entsprechend aktualisiert.
  • Ich habe dasDokument CONTRIBUTINGgelesen.
  • Ich habe Tests hinzugefügt, um meine Änderungen abzudecken.
  • Alle neuen und bestehenden Tests bestanden.

aguschin referenced this pull request in iterative/gto

Dec 21, 2022

ivan-magda

gh extension install actions/gh-actions-cache

REPO=${{ github.repository }}
BRANCH=${{ github.ref }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.base_ref would be the parent branch, github.ref is the merge branch

estahn pushed a commit to estahn/k8s-image-swapper that referenced this pull request

Jan 1, 2023 
## [1.4.0](v1.3.3...v1.4.0) (2023-01-01)

### 👷 Build System

* **deps-dev:** Bump @semantic-release/changelog from 6.0.1 to 6.0.2 ([#404](#404)) ([ee56dbc](ee56dbc)), closes [#276](#276) [#276](#276) [#272](#272) [#275](#275) [#273](#273) [#274](#274) [#271](#271) [#270](#270) [#269](#269) [#268](#268) [#267](#267)

### 🎉 Features

* add custom tags to created ECR repositories ([#191](#191)) ([9849df2](9849df2))

### 📝 Documentation

* fix indentation ([b00c57e](b00c57e))

### ⬆️ Dependencies

* **deps:** Bump actions/cache from 3.0.11 to 3.2.1 ([#417](#417)) ([7e7eb8f](7e7eb8f)), closes [actions/cache#1039](actions/cache#1039) [actions/cache#1023](actions/cache#1023) [actions/cache#959](actions/cache#959) [actions/cache#960](actions/cache#960) [actions/cache#963](actions/cache#963) [actions/cache#961](actions/cache#961) [actions/cache#976](actions/cache#976) [actions/cache#971](actions/cache#971) [actions/cache#979](actions/cache#979) [actions/cache#986](actions/cache#986) [actions/cache#981](actions/cache#981) [actions/cache#997](actions/cache#997) [actions/cache#998](actions/cache#998) [actions/cache#1005](actions/cache#1005) [actions/cache#1007](actions/cache#1007) [actions/cache#1013](actions/cache#1013) [actions/cache#1004](actions/cache#1004) [actions/cache#1014](actions/cache#1014) [actions/cache#1008](actions/cache#1008) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1035](actions/cache#1035) [actions/cache#959](actions/cache#959) [actions/cache#979](actions/cache#979) [actions/cache#1013](actions/cache#1013) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1006](actions/cache#1006) [#1023](#1023) [#1039](#1039) [#1035](#1035) [#929](#929) [#1026](#1026) [#1008](#1008) [#1014](#1014) [#1004](#1004)
* **deps:** Bump actions/setup-python from 4.3.0 to 4.3.1 ([#406](#406)) ([16da762](16da762)), closes [actions/setup-python#559](actions/setup-python#559) [actions/setup-python#511](actions/setup-python#511) [actions/setup-python#558](actions/setup-python#558) [#559](#559) [#558](#558) [#549](#549) [#546](#546) [#545](#545) [#535](#535) [#510](#510) [#511](#511) [#520](#520)
* **deps:** Bump actions/setup-python from 4.3.1 to 4.4.0 ([#418](#418)) ([77872f8](77872f8)), closes [actions/setup-python#566](actions/setup-python#566) [#567](#567) [#569](#569) [#566](#566)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.146 to 1.44.152 ([#403](#403)) ([9db51fd](9db51fd)), closes [#4652](https://github.com/estahn/k8s-image-swapper/issues/4652) [#4650](https://github.com/estahn/k8s-image-swapper/issues/4650) [#4648](https://github.com/estahn/k8s-image-swapper/issues/4648) [#4647](https://github.com/estahn/k8s-image-swapper/issues/4647) [#4646](https://github.com/estahn/k8s-image-swapper/issues/4646) [#4644](https://github.com/estahn/k8s-image-swapper/issues/4644) [#4639](https://github.com/estahn/k8s-image-swapper/issues/4639)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.152 to 1.44.157 ([#411](#411)) ([2188432](2188432)), closes [#4658](https://github.com/estahn/k8s-image-swapper/issues/4658) [#4657](https://github.com/estahn/k8s-image-swapper/issues/4657) [#4656](https://github.com/estahn/k8s-image-swapper/issues/4656) [#4654](https://github.com/estahn/k8s-image-swapper/issues/4654) [#4653](https://github.com/estahn/k8s-image-swapper/issues/4653)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.157 to 1.44.162 ([#415](#415)) ([f70fcd9](f70fcd9)), closes [#4666](https://github.com/estahn/k8s-image-swapper/issues/4666) [#4665](https://github.com/estahn/k8s-image-swapper/issues/4665) [#4663](https://github.com/estahn/k8s-image-swapper/issues/4663) [#4661](https://github.com/estahn/k8s-image-swapper/issues/4661) [#4660](https://github.com/estahn/k8s-image-swapper/issues/4660)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.162 to 1.44.167 ([#419](#419)) ([f8b91fe](f8b91fe)), closes [#4671](https://github.com/estahn/k8s-image-swapper/issues/4671) [#4670](https://github.com/estahn/k8s-image-swapper/issues/4670) [#4669](https://github.com/estahn/k8s-image-swapper/issues/4669) [#4668](https://github.com/estahn/k8s-image-swapper/issues/4668) [#4667](https://github.com/estahn/k8s-image-swapper/issues/4667)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.3 to 0.41.4 ([#402](#402)) ([16dde07](16dde07)), closes [#1208](https://github.com/estahn/k8s-image-swapper/issues/1208)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.4 to 0.41.6 ([#409](#409)) ([9fc87df](9fc87df)), closes [#1214](https://github.com/estahn/k8s-image-swapper/issues/1214) [#1198](https://github.com/estahn/k8s-image-swapper/issues/1198)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 ([#420](#420)) ([9ab97f2](9ab97f2)), closes [gruntwork-io/terratest#1217](gruntwork-io/terratest#1217) [#1217](https://github.com/estahn/k8s-image-swapper/issues/1217)
* **deps:** Bump goreleaser/goreleaser-action from 3.1.0 to 4.1.0 ([#414](#414)) ([e963ba1](e963ba1)), closes [goreleaser/goreleaser-action#382](goreleaser/goreleaser-action#382) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#383](goreleaser/goreleaser-action#383) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#370](goreleaser/goreleaser-action#370) [#374](#374) [#372](#372) [#373](#373) [#383](#383) [#366](#366) [#382](#382) [#370](#370)
* **deps:** Bump k8s.io/api from 0.25.4 to 0.26.0 ([#407](#407)) ([d13bf5e](d13bf5e)), closes [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375) [#113186](https://github.com/estahn/k8s-image-swapper/issues/113186)
* **deps:** Bump k8s.io/client-go from 0.25.4 to 0.26.0 ([#410](#410)) ([bcc56b5](bcc56b5)), closes [#113797](https://github.com/estahn/k8s-image-swapper/issues/113797) [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113826](https://github.com/estahn/k8s-image-swapper/issues/113826) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375)

Reviewers

@lvpx lvpx Awaiting requested review from lvpx

@kotewar kotewar Awaiting requested review from kotewar

@pallavx pallavx Awaiting requested review from pallavx

3 more reviewers

@ivan-magda ivan-magda ivan-magda left review comments

Reviewers whose approvals may not affect merge requirements