add restore cache error handling by panticmilos · Pull Request #434 · actions/setup-python
Navigation Menu
{{ message }}
actions / setup-python Public
- Notifications You must be signed in to change notification settings
- Fork 703
Closed
panticmilos wants to merge 3 commits intoactions:mainfrom
Closed
add restore cache error handling#434
panticmilos wants to merge 3 commits intoactions:mainfrom
add restore cache error handling#434
panticmilos wants to merge 3 commits intoactions:mainfrom
Conversation
Copy link
Contributor
panticmilos
commented
Jun 14, 2022
panticmilos
commented
Description:
This PR provides error handling for cache restore functionality.
Check list:
- Mark if documentation changes are required.
- Mark if tests were added or updated to cover the changes.
panticmilos
requested a review
from a team
marko-zivic-93 approved these changes Jun 14, 2022
dmitry-shibanov approved these changes Jun 14, 2022
vsafonkin approved these changes Jun 14, 2022
brcrista reviewed Jun 14, 2022
| restoreKey | ||
| ); | ||
| try { | ||
| const matchedKey = await cache.restoreCache( |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we push this fix into restoreCache from actions/cache? That way everything that uses caching will handle 503s correctly.
brcrista suggested changes Jun 14, 2022
Copy link
Contributor
brcrista
left a comment
brcrista
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should push the fix into the actions/cache package so everything gets fixed and is future-proofed
LadyK-21
mentioned this pull request
Copy link
Contributor
brcrista
commented
Jun 29, 2022
brcrista commented
Jun 29, 2022#448 will fix this
brcrista
closed this
MarcelRaschke
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants