Using some Java8 features on DecisionTreeLearner and DataSet by AdrianBZG · Pull Request #296 · aimacode/aima-java
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 805
Closed
AdrianBZG wants to merge 2 commits intoaimacode:AIMA3efrom
Closed
Using some Java8 features on DecisionTreeLearner and DataSet#296
AdrianBZG wants to merge 2 commits intoaimacode:AIMA3efrom
Using some Java8 features on DecisionTreeLearner and DataSet#296
AdrianBZG wants to merge 2 commits intoaimacode:AIMA3efrom
Conversation
Copy link Copy Markdown
Just a few changes, using Java8 features:
-
Check allExampleHaveSameClassification: DecisionTreeLearner.java (L139-L143) and chooseAttribute (L122-L137) on commit f20a270
-
Check calculateGainFor on DataSet.java (L101-114)
AdrianBZG
force-pushed
the
AIMA3e
branch
2 times, most recently
from
016942b to
55fc621
Compare
AdrianBZG
force-pushed
the
AIMA3e
branch
from
55fc621 to
a283ed7
Compare
Copy link Copy Markdown
Contributor
Hi,
The AIMA4e branch is the intended target for introducing JDK 8 features. While AIMA3e is now based on JDK 8 as well these types of changes to its source base are unnecessary. Also, switching to streams() for the sake of using streams() is not necessarily a good idea. See the discussion here:
If you can just fix the glitch and test case in a clean/separate pull request I'll re-review.
Best
Ciaran
ctjoreilly
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants