Fixing a few sonar code quality violations by alainlompo · Pull Request #336 · aimacode/aima-java
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 805
Closed
alainlompo wants to merge 1 commit intoaimacode:AIMA3efrom
Closed
Fixing a few sonar code quality violations#336
alainlompo wants to merge 1 commit intoaimacode:AIMA3efrom
Fixing a few sonar code quality violations#336
alainlompo wants to merge 1 commit intoaimacode:AIMA3efrom
Conversation
samagra14 requested changes May 31, 2018
| if (isValidMatch(toMatch, toMatchVariables, variable, | ||
| substitution)) { | ||
| // Fixing squid:s1066 | ||
| if (null != (substitution = unifier.unify(toMatch, variable)) |
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these comments? The changes look fine.
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please have a look at the conflicts.
samagra14
added
the
AIMA3e
label
samagra14
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment