fn by syuilo · Pull Request #210 · aiscript-dev/aiscript

What

Resolve #179

Why

Additional info (optional)

Codecov Report

Base: 77.41% // Head: 77.41% // No change to project coverage 👍

Coverage data is based on head (28903fe) compared to base (b9018de).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   77.41%   77.41%           
=======================================
  Files          20       20           
  Lines        2759     2759           
  Branches      426      426           
=======================================
  Hits         2136     2136           
  Misses        615      615           
  Partials        8        8

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.


		FnDef
		= "@" s1:__* name:NAME s2:__* "(" _* args:Args? _* ")" ret:(_* ":" _* @Type)? _* "{" _* content:Statements? _* "}"
		= "fn" _+ name:NAME s1:__* "(" _* args:Args? _* ")" _* ret:(_* "=>" _* @Type)? _* "{" _* content:Statements? _* "}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これって:は型の指定をする時の記号だけど、これを=>にするという意図？

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あーそう
ついでに=>にしてみた(Rustとかだとそう)

		// function expression

		Fn = "@(" _* args:Args? _* ")" ret:(_* ":" _* @Type)? _* "{" _* content:Statements? _* "}"
		Fn = "(" _* args:Args? _* ")" _* ret:(_* ":" _* @Type)? _* "=>" _* "{" _* content:Statements? _* "}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありふれている記号列ではスペースや改行の扱いはよく検討する必要がありそう

syuilo marked this pull request as ready for review

August 30, 2022 14:23