Fix for #893 - param annotation name not coming up in report by mr-possible · Pull Request #1130 · allure-framework/allure-java
Navigation Menu
{{ message }}
allure-framework / allure-java Public
- Notifications You must be signed in to change notification settings
- Fork 237
Open
mr-possible wants to merge 1 commit intoallure-framework:mainfrom
Open
Fix for #893 - param annotation name not coming up in report#1130
mr-possible wants to merge 1 commit intoallure-framework:mainfrom
Fix for #893 - param annotation name not coming up in report#1130
mr-possible wants to merge 1 commit intoallure-framework:mainfrom
Conversation
Copy link Copy Markdown
baev requested changes Sep 25, 2024
allure-testng/src/test/resources/suites/parameterized-test.xml
Outdated
Show resolved
Hide resolved
allure-testng/src/test/resources/suites/parameterized-test.xml Outdated Show resolved Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/samples/ParameterizedTest.java
Outdated
Show resolved
Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/samples/ParameterizedTest.java Outdated Show resolved Hide resolved
mr-possible
force-pushed
the
main
branch
from
b85e6ae to
e19178f
Compare
mr-possible
requested a review
from baev
baev requested changes Sep 25, 2024
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use wildcard imports. Otherwise — great job 👍
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java Outdated Show resolved Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java Outdated Show resolved Hide resolved
mr-possible
force-pushed
the
main
branch
from
e19178f to
603bd6f
Compare
mr-possible
requested a review
from baev
baev approved these changes Sep 26, 2024
mr-possible
requested a review
from baev
mr-possible
force-pushed
the
main
branch
2 times, most recently
from
b4cd9ad to
603bd6f
Compare
Copy link Copy Markdown
Author
mr-possible
commented
Nov 25, 2024
mr-possible commented
Nov 25, 2024hey @baev , can we merge this?
mr-possible
force-pushed
the
main
branch
from
603bd6f to
125f7b5
Compare
baev
removed their request for review
mr-possible
force-pushed
the
main
branch
from
125f7b5 to
6c5b105
Compare
Copy link Copy Markdown
Author
mr-possible
commented
May 23, 2025
mr-possible commented
May 23, 2025Can we merge this ? @baev It's been sitting since quite long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment