Update Action for GitHub enterprise by j-puri · Pull Request #125 · allure-framework/setup-allurectl
Navigation Menu
{{ message }}
allure-framework / setup-allurectl Public
- Notifications You must be signed in to change notification settings
- Fork 4
Open
j-puri wants to merge 3 commits intoallure-framework:mainfrom
Open
Update Action for GitHub enterprise#125
j-puri wants to merge 3 commits intoallure-framework:mainfrom
Update Action for GitHub enterprise#125
j-puri wants to merge 3 commits intoallure-framework:mainfrom
Conversation
Copy link Copy Markdown
Update Action for Use on GitHub Enterprise
Currently the action doesn't seem to be useable for Workflows running on GitHub Enterprise. This is because:
getVersion()relies on Oktokit defaulting the baseUrl. In Enterprise, this baseUrl appears to be defaulted to the enterprise URL rather than public GitHub.- The GitHub token provided by a Workflow may not be able to authenticate with the GitHub API on https://api.github.com/ if it limited by scope - this is needed by
getVersion() - The token needed by
setUpTool()may therefore need to be different from the token used bygetVersion().
Proposed changes:
- Hardcode the GitHub API URL to get releases by tag so it doesn't default to the Enterprise URL
- Add an additional Action input to set a different token used by the setUpTool function to set Allure job metadata. This is defaulted to
${{ github.token }}to avoid regressions.
j-puri added 2 commits
February 7, 2023 13:47Copy link Copy Markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment