Update Action for GitHub enterprise by j-puri · Pull Request #125 · allure-framework/setup-allurectl

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@j-puri

Copy link Copy Markdown

@j-puri j-puri commented

Feb 7, 2023

edited

Loading

Update Action for Use on GitHub Enterprise

Currently the action doesn't seem to be useable for Workflows running on GitHub Enterprise. This is because:

  1. getVersion() relies on Oktokit defaulting the baseUrl. In Enterprise, this baseUrl appears to be defaulted to the enterprise URL rather than public GitHub.
  2. The GitHub token provided by a Workflow may not be able to authenticate with the GitHub API on https://api.github.com/ if it limited by scope - this is needed by getVersion()
  3. The token needed by setUpTool() may therefore need to be different from the token used by getVersion().

Proposed changes:

  1. Hardcode the GitHub API URL to get releases by tag so it doesn't default to the Enterprise URL
  2. Add an additional Action input to set a different token used by the setUpTool function to set Allure job metadata. This is defaulted to ${{ github.token }} to avoid regressions.

@CLAassistant

Copy link Copy Markdown

CLAassistant commented

Feb 7, 2023

edited

Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-puri @CLAassistant