[JetSurvey] Use AnimatedContent to slide in and out changes between questions by riggaroo · Pull Request #842 · android/compose-samples
Conversation
Added two usages of AnimatedContent into JetSurvey.
- Switching between Question Content
| Before | After |
|---|---|
 |
 |
- Switching from questions to results
| Before | After |
|---|---|
 |
 |
Animate the changes between different question screens, as well as the end result screen.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you! I had just one super minor comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| JetsurveyTheme { | ||
| viewModel.uiState.observeAsState().value?.let { surveyState -> | ||
| when (surveyState) { | ||
| val state = viewModel.uiState.observeAsState().value ?: return@JetsurveyTheme |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the ?: return@JetsurveyTheme change?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
riggaroo
deleted the
riggaroo/jetsurvey-animated-content
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters