[Crane] Use AnimatedContent to transition between content states. by riggaroo · Pull Request #843 · android/compose-samples

@riggaroo

@riggaroo

simona-anomis

simona-anomis

simona-anomis

slideOutOfContainer(
towards = direction,
animationSpec = tween(600)
) using SizeTransform(clip = false, sizeAnimationSpec = { initialSize, targetSize ->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nit: I'd push SizeTransform into a new line and split out its params into individual rows, just for readability

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the notion with it can't be split onto a new line as its actually an argument

simona-anomis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit comments, feel free to not resolve them :)

@riggaroo riggaroo deleted the riggaroo/animated-content-crane branch

June 20, 2022 14:07