Allow overriding init timeout via parameters by haggholm · Pull Request #206 · andywer/threads.js
Navigation Menu
{{ message }}
andywer / threads.js Public
- Notifications You must be signed in to change notification settings
- Fork 170
Merged
Allow overriding init timeout via parameters#206
andywer merged 1 commit intoandywer:masterfrom
Allow overriding init timeout via parameters#206
andywer merged 1 commit intoandywer:masterfrom
Conversation
Copy link Copy Markdown
Contributor
haggholm
commented
Feb 5, 2020
haggholm
commented
We have some environments (involving Docker containers or Webpack builds, &c., &c.) where (a) setting the timeout via env var is awkward, and (b) some development machines experience timeouts. It would be nice to be able to override the default timeout via parameters.
…r than environment variable
Copy link Copy Markdown
Owner
andywer
commented
Feb 5, 2020
andywer commented
Feb 5, 2020Hey @haggholm, that makes sense!
Thanks for the contribution 👍
andywer
merged commit
b50087a
into
andywer:master
Copy link Copy Markdown
Owner
andywer
commented
Feb 7, 2020
andywer commented
Feb 7, 2020Published as v1.1.0 🚀
andywer
mentioned this pull request
kellyselden added a commit to kellyselden/threads.js that referenced this pull request
Oct 8, 2020I spent half the day scratching my head on this one. I searched your repo for "docker" and found [this issue](andywer#206), which solved it. I would like to make it easier for others to find this solution.
kellyselden
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants