Test and build in separate jobs by aminya · Pull Request #351 · andywer/threads.js

@aminya

This allows using the latest tools for building on the latest Node.js while supporting older versions for running the code

Fixes the errors in #349

@aminya

@aminya

@aminya aminya marked this pull request as draft

March 27, 2021 16:50

@aminya

@aminya

@aminya

@aminya aminya marked this pull request as ready for review

March 27, 2021 19:24

@aminya

@andywer

Cool, great idea!

I'm just wondering why the test/ directory has been renamed to test-dev/ and what's the story behind the two npm test scripts? 😉

@aminya

Thanks!

I separated the runtime tests from dev time tests. Dev time tests (such as bundling with Webpack and Rollup) are tested on the latest Node, and all the other tests are tested on old Node. This allows us to use the latest tools while keeping backward compatibility for old runtimes.

@andywer

Sounds reasonable. My only issue is that the npm script names failed to convey their purpose to me…

How about test:library & test:tooling instead? Or maybe test:integration for the latter. WDYT?

Don't want to unnecessarily delay the merge, but since we cannot add comments to the package.json, we should pay a bit of extra attention to the naming there 🙂

@aminya

Sounds reasonable. My only issue is that the npm script names failed to convey their purpose to me…

How about test:library & test:tooling instead? Or maybe test:integration for the latter. WDYT?

Don't want to unnecessarily delay the merge, but since we cannot add comments to the package.json, we should pay a bit of extra attention to the naming there 🙂

Sure, that sounds good to me.

@aminya

@aminya aminya deleted the separate-build-test branch

March 29, 2021 17:04