fix(compiler): not generating update instructions for ng-template inside alternate namespaces by crisbeto · Pull Request #41669

fix(compiler): not generating update instructions for ng-template inside alternate namespaces by crisbeto · Pull Request #41669 · angular/angular

…ide alternate namespaces

We have a check that determines whether to generate property binding instructions for an `ng-template`. The check looks at whether the tag name is exactly `ng-template`, but the problem is that if the tag is placed in a non-HTML namespace (e.g. `svg`), the tag name will actually be `:namespace:ng-template` and the check will fail.

These changes resolve the issue by looking at the tag name without the namespace.

Fixes angular#41308.

crisbeto added action: review

The PR is still awaiting reviews from at least one requested reviewer

area: compiler

Issues related to `ngc`, Angular's template compiler

target: rc

This PR is targeted for the next release-candidate

labels

Apr 17, 2021

crisbeto marked this pull request as ready for review

April 17, 2021 09:49

AndrewKushnir pushed a commit that referenced this pull request

Apr 20, 2021

…ide alternate namespaces (#41669)

We have a check that determines whether to generate property binding instructions for an `ng-template`. The check looks at whether the tag name is exactly `ng-template`, but the problem is that if the tag is placed in a non-HTML namespace (e.g. `svg`), the tag name will actually be `:namespace:ng-template` and the check will fail.

These changes resolve the issue by looking at the tag name without the namespace.

Fixes #41308.

PR Close #41669