fix: remove deprecated JSON parser, use workspace helpers by fmalcher · Pull Request #139 · angular-schule/angular-cli-ghpages
Navigation Menu
{{ message }}
angular-schule / angular-cli-ghpages Public
- Notifications You must be signed in to change notification settings
- Fork 98
Merged
fix: remove deprecated JSON parser, use workspace helpers#139
JohannesHoppe merged 2 commits intomasterfrom
fix: remove deprecated JSON parser, use workspace helpers#139
JohannesHoppe merged 2 commits intomasterfrom
Conversation
Copy link
Member
fix #138 . This also SEEMS to fix issue #137 – at least I didn't get any similar errors.
Things worth to know:
- reading/writing the workspace has completely moved to the builtin helpers
- some error messages have changed
- the empty options object is automatically removed. We could statically add one option there so that the object is not empty.
see also: https://angular.io/guide/schematics-for-libraries#define-a-generation-rule
fmalcher
requested a review
from JohannesHoppe
fmalcher commented Nov 5, 2021
src/package.json
Outdated
Show resolved
Hide resolved
src/package.json Outdated Show resolved Hide resolved
fmalcher
marked this pull request as draft
fmalcher
force-pushed
the
ngadd13
branch
from
f6eb6c6 to
8feb42c
Compare
fmalcher
changed the title
fix: don't use deprecated JSON parser
fix: remove deprecated JSON parser, use workspace helpers
fmalcher
force-pushed
the
ngadd13
branch
3 times, most recently
from
1c091f7 to
cc8ea0c
Compare
fmalcher
force-pushed
the
ngadd13
branch
from
cc8ea0c to
e4b7896
Compare
fmalcher
marked this pull request as ready for review
JohannesHoppe approved these changes Nov 19, 2021
Copy link
Member
JohannesHoppe
commented
Nov 19, 2021
JohannesHoppe commented
Nov 19, 2021
JohannesHoppe
merged commit
aa7ea02
into
master
JohannesHoppe
deleted the
ngadd13
branch
Copy link
Member
JohannesHoppe
commented
Nov 19, 2021
JohannesHoppe commented
Nov 19, 2021I just published angular-cli-ghpages@1.0.0-rc.3 to npm!
JohannesHoppe
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants