Fix 3052 by l215884529 · Pull Request #3053 · antlr/antlr4
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.4k
Merged
ericvergnaud merged 2 commits intoantlr:masterfrom
Jan 27, 2021Merged
Fix 3052#3053
ericvergnaud merged 2 commits intoantlr:masterfrom
Fix 3052#3053
ericvergnaud merged 2 commits intoantlr:masterfrom
Conversation
Copy link
Contributor
l215884529
commented
Jan 25, 2021
l215884529
commented
Fix #3052.
The problem is caused by an undefined ruleIndex attribute.
Calling getRuleIndex() method instead of accessing the ruleIndex attribute solves this problem.
Copy link
Contributor
ericvergnaud
commented
Jan 25, 2021
ericvergnaud commented
Jan 25, 2021Hi,
thanks for this but unfortunately our CI is currently down, so can't assess the impact of this proposed change.
Is it ok to park this for a week or so until the CI is fixed?
Copy link
Contributor Author
l215884529
commented
Jan 26, 2021
l215884529 commented
Jan 26, 2021Thank you for the quick reply.
It's totally fine for me :)
Copy link
Contributor
ericvergnaud
commented
Jan 27, 2021
ericvergnaud commented
Jan 27, 2021Hi,
the CI is fixed
can you touch the PR at your end in order to trigger checks?
thanks
l215884529
force-pushed
the
fix-3052
branch
from
6868d64 to
48a3f60
Compare
l215884529 added 2 commits
January 27, 2021 15:07
l215884529
force-pushed
the
fix-3052
branch
from
48a3f60 to
ac9d62a
Compare
ericvergnaud
merged commit
62a0b02
into
antlr:master
ericvergnaud
added this to the
4.9.2 milestone
parrt
added
target:python3
type:bug
labels
This was referenced
Mar 12, 2021This was referenced
Mar 12, 2021This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment