[Go] Fix null pointer dereference by SKalt · Pull Request #3284 · antlr/antlr4
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.4k
Merged
parrt merged 3 commits intoantlr:masterfrom
Oct 22, 2021Merged
[Go] Fix null pointer dereference#3284
parrt merged 3 commits intoantlr:masterfrom
[Go] Fix null pointer dereference#3284
parrt merged 3 commits intoantlr:masterfrom
Conversation
Copy link
Contributor
SKalt
commented
Sep 24, 2021
SKalt
commented
SKalt
changed the title
[Go] Fix null ptr dereference
[Go] Fix null pointer dereference
Copy link
Contributor
kaby76
commented
Sep 24, 2021
kaby76 commented
Sep 24, 2021This looks good--it does what is exactly done for superClass in the parser. Thank you for fixing this.
Copy link
Contributor Author
SKalt
commented
Sep 28, 2021
SKalt commented
Sep 28, 2021I'm getting one failing test with the message
Running org.antlr.v4.test.runtime.csharp.TestLeftRecursion Too long with no output (exceeded 10m0s): context deadline exceeded
I don't think that test is actually running my changes (I'd expect runtime.csharp is using the c# runtime, not parsing c# using go). I'm going to rebase on the development branch and retry the tests.
SKalt added 2 commits
September 29, 2021 20:45Fixes antlr#3254; this is the exact fix recommended by @kaby76.
SKalt
force-pushed
the
fix-3254-go-null-ptr-dereference
branch
from
4bfb194 to
34aa551
Compare
kaby76
mentioned this pull request
parrt
added
the
target:go
label
parrt
added this to the
4.9.3 milestone
parrt
merged commit
4340382
into
antlr:master
SKalt
deleted the
fix-3254-go-null-ptr-dereference
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment