Fix some thread sanitizer warnings in C++ runtime by jcking · Pull Request #3309 · antlr/antlr4
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.4k
Merged
parrt merged 2 commits intoantlr:masterfrom
Oct 31, 2021Merged
Fix some thread sanitizer warnings in C++ runtime#3309
parrt merged 2 commits intoantlr:masterfrom
Fix some thread sanitizer warnings in C++ runtime#3309
parrt merged 2 commits intoantlr:masterfrom
Conversation
Copy link
Collaborator
jcking
commented
Oct 15, 2021
jcking
commented
There are some shared global states in the C++ runtime, specifically in the ATN, that cause thread sanitizer warnings. This pull request switches those use std::atomic.
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
2 times, most recently
from
edee543 to
5bc8e01
Compare
Copy link
Collaborator Author
jcking
commented
Oct 18, 2021
jcking commented
Oct 18, 2021
Copy link
Member
mike-lischke
commented
Oct 19, 2021
mike-lischke commented
Oct 19, 2021Thanks for the PR. Can you also add yourself to the contributors.txt file?
Copy link
Collaborator Author
jcking
commented
Oct 19, 2021
jcking commented
Oct 19, 2021Thanks for the PR. Can you also add yourself to the contributors.txt file?
Done.
Copy link
Collaborator Author
jcking
commented
Oct 19, 2021
jcking commented
Oct 19, 2021Thanks for the PR. Can you also add yourself to the contributors.txt file?
Done.
Actually, I added it to #3311 instead, but same outcome. Both are TSAN fixes.
Copy link
Member
mike-lischke
commented
Oct 22, 2021
mike-lischke commented
Oct 22, 2021Please add that to this PR (too). We may not accept both patches.
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
from
5bc8e01 to
f68a89d
Compare
Copy link
Collaborator Author
jcking
commented
Oct 22, 2021
jcking commented
Oct 22, 2021Please add that to this PR (too). We may not accept both patches.
Done.
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
from
f68a89d to
0d0e7b4
Compare
mike-lischke approved these changes Oct 31, 2021
Copy link
Member
mike-lischke
commented
Oct 31, 2021
mike-lischke commented
Oct 31, 2021@parrt Another C++ only patch, ready to be merged.
parrt
added
the
target:cpp
label
parrt
added this to the
4.9.3 milestone
parrt
merged commit
6ab9d0f
into
antlr:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment