Home Original page

do not modify String.prototype in js package by jharris4 · Pull Request #4200 · antlr/antlr4

@jharris4

@jharris4

Not sure if THIRD-PARTY-NOTICES.txt should be updated/deleted to reflect the changes in this PR...?

@jharris4 

Signed-off-by: Jon Harris <harris.jb@gmail.com>

ericvergnaud

*/

import Token from './Token.js';
import './polyfills/codepointat.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does removing this relate to the PR ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvergnaud

Yes THIRD-PARTY-NOTICES should be removed

@jharris4 

Signed-off-by: Jon Harris <harris.jb@gmail.com>

@ericvergnaud

jimidle pushed a commit to jimidle/antlr4 that referenced this pull request

Mar 28, 2023 
* do not modify String.prototype in js package

Signed-off-by: Jon Harris <harris.jb@gmail.com>

* remove notice file that is no longer relevant

Signed-off-by: Jon Harris <harris.jb@gmail.com>

---------

Signed-off-by: Jon Harris <harris.jb@gmail.com>
Signed-off-by: Jim.Idle <jimi@idle.ws>