Summary of Changes

Hello @damccorm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR addresses a bug in the Java SDK where pipeline options were not propagated to external transforms. The fix involves reordering a method call in External.java to ensure setPipelineOptions is called on the builder before the request is built, thereby correctly including the options in the ExpansionRequest.

Highlights

• Intent: This pull request aims to fix a bug where pipeline options were not being correctly passed to external transforms when using the Java SDK. The issue stemmed from setting the pipeline options on a builder after the request object had already been built, rendering the setting ineffective.
• Changes: The core change is in sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/External.java. The setPipelineOptions call for the requestBuilder has been moved to occur before the build() method is invoked. This ensures that the pipeline options are properly incorporated into the ExpansionRequest object before it is finalized and sent.
• Reviewer Activity: No specific reviewer activity or comments were provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩