[Dataflow Streaming] Add support to read user worker settings from backend by arunpandianp · Pull Request #32408 · apache/beam
arunpandianp
changed the title
[WIP] [Dataflow Streaming] Add support to read user worker settings from backend
[Dataflow Streaming] Add support to read user worker settings from backend
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers
This is ready for review, the failing test looks unrelated to the change.
| */ | ||
| package org.apache.beam.runners.dataflow.worker.streaming.config; | ||
|
|
||
| import com.google.common.base.Preconditions; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use vendored
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Should we remove the unvendored dependency from the classpath somehow?
todo: Manage the threadpool shutdown
Modified StreamingGlobalConfigHandleImpl to queue callbacks internally without relying on executors. PTAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters