Add use_gbek service option when gbek option used by damccorm · Pull Request #36452 · apache/beam

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Dataflow runner's option handling by automatically including the use_gbek service option when the gbek pipeline option is specified. This change aims to streamline policy enforcement for users, ensuring that use_gbek is only enabled through the designated gbek option, thereby preventing misconfigurations and promoting secure practices across both Java and Python SDKs.

Highlights

  • Automatic use_gbek option handling: When the --gbek pipeline option is provided, the use_gbek service option is automatically added to the Dataflow service options in both Java and Python runners. This ensures consistency and allows for policy enforcement.
  • Enforced use_gbek usage: Direct setting of use_gbek in dataflow_service_options is now disallowed. Users must use the --gbek pipeline option, which then implicitly adds use_gbek. An IllegalArgumentException (Java) or ValueError (Python) is thrown if use_gbek is set directly without --gbek.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.