Check if master node before schedule gremlin job by Linary · Pull Request #1314 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
Check if master node before schedule gremlin job#1314
Check if master node before schedule gremlin job#1314
Conversation
Copy link
Contributor
Linary
commented
Dec 25, 2020
Linary
commented
Change-Id: I9ef3e1f3f4d30ae8b252a53c148b0b0759eff472
Change-Id: I9ef3e1f3f4d30ae8b252a53c148b0b0759eff472
javeme requested changes Dec 25, 2020
| public void waitUntilAllTasksCompleted(long seconds) | ||
| throws TimeoutException; | ||
|
|
||
| default public void checkRequirement(String op) { |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't set default
Change-Id: I5d6b29ce78e896a3a7f483c696f8d0da71d4b784
javeme approved these changes Dec 28, 2020
houzhizhen approved these changes Dec 28, 2020
Copy link
Codecov Report
Merging #1314 (c8d9673) into master (f6c9850) will increase coverage by
0.65%.
The diff coverage is50.00%.
@@ Coverage Diff @@ ## master #1314 +/- ## ============================================ + Coverage 61.67% 62.33% +0.65% - Complexity 5752 5773 +21 ============================================ Files 377 377 Lines 31501 31508 +7 Branches 4413 4412 -1 ============================================ + Hits 19428 19640 +212 + Misses 10088 9875 -213 - Partials 1985 1993 +8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update f6c9850...c8d9673. Read the comment docs.
Linary
merged commit
717d93e
into
master
Linary
deleted the
check-before-schedule-job
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants