fix jaccard similarity NaN by zhoney · Pull Request #1324 · apache/hugegraph
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 583
Merged
Conversation
Copy link
Contributor
zhoney
commented
Jan 6, 2021
zhoney
commented
Change-Id: I78a3f3da2be5480712f4545fbc93daad77f0bf1d
Change-Id: I78a3f3da2be5480712f4545fbc93daad77f0bf1d
javeme reviewed Jan 6, 2021
| int unionNum = CollectionUtil.union(set1, set2).size(); | ||
| if (unionNum == 0) { | ||
| return 0.0D; | ||
| } |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct title typo
zhoney
changed the title
fix jaccard similarity nan
fix jaccard similarity NaN
javeme approved these changes Jan 6, 2021
Copy link
Codecov Report
Merging #1324 (049263a) into master (26ac664) will increase coverage by
0.43%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #1324 +/- ## ============================================ + Coverage 61.88% 62.32% +0.43% - Complexity 5751 5772 +21 ============================================ Files 377 377 Lines 31543 31543 Branches 4419 4419 ============================================ + Hits 19521 19658 +137 + Misses 10029 9887 -142 - Partials 1993 1998 +5
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| .../baidu/hugegraph/backend/query/ConditionQuery.java | 86.40% <0.00%> (+0.40%) |
106.00% <0.00%> (+1.00%) |
|
| .../backend/store/cassandra/CassandraSessionPool.java | 57.14% <0.00%> (+1.02%) |
11.00% <0.00%> (ø%) |
|
| ...h/backend/store/scylladb/ScyllaDBTablesWithMV.java | 96.03% <0.00%> (+96.03%) |
10.00% <0.00%> (+10.00%) |
|
| ...graph/backend/store/scylladb/ScyllaDBFeatures.java | 100.00% <0.00%> (+100.00%) |
3.00% <0.00%> (+3.00%) |
|
| .../backend/store/scylladb/ScyllaDBStoreProvider.java | 100.00% <0.00%> (+100.00%) |
7.00% <0.00%> (+7.00%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 26ac664...049263a. Read the comment docs.
Linary approved these changes Jan 7, 2021
Linary
merged commit
52a8aae
into
master
Linary
deleted the
fix-jaccard-similar-nan
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants